Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

copr: Also install git #660

Merged
merged 1 commit into from
Jul 2, 2024
Merged

copr: Also install git #660

merged 1 commit into from
Jul 2, 2024

Conversation

cgwalters
Copy link
Collaborator

This whole "install all the build tools to make a source rpm" flow rather stinks...

One thing that would help is for me (or someone else) to package cargo-vendor-filterer at some point.

@cgwalters
copr: Also install git
947e70c 
This whole "install all the build tools to make a source rpm"
flow rather stinks...

One thing that would help is for me (or someone else) to package
cargo-vendor-filterer at some point.

Signed-off-by: Colin Walters <walters@verbum.org>
vrothberg
vrothberg approved these changes Jul 2, 2024
View reviewed changes
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cgwalters cgwalters merged commit 182a1ed into containers:main Jul 2, 2024
15 of 19 checks passed
@cgwalters
Copy link
Collaborator Author

OK well, that improved things but maddeningly enough it's still broken and the reason appears to be that the make srpm process runs in a f39 root. Why is it using f39? Well, there's all sorts of mock/copr magic going on there. The thing is, this would all be so much more obvious if building the SRPM just ran in a standard container image.


You can reproduce this build on your computer by running:

  sudo dnf install copr-rpmbuild
  /usr/bin/copr-rpmbuild --verbose --drop-resultdir --srpm --task-url https://copr.fedorainfracloud.org/backend/get-srpm-build-task/7698092

I mean yeah but, why can't I reproduce it with podman run?

OK anyways trying #664

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vrothberg vrothberg vrothberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cgwalters @vrothberg